Propagate image-animation to viewport and enable repeat#59264
Draft
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Draft
Propagate image-animation to viewport and enable repeat#59264chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
chromium-wpt-export-bot wants to merge 1 commit intomasterfrom
Conversation
Currently, the 'image-animation' property is not correctly propagated from the root element to the viewport, and so root backgrounds fail to respect the animation control. Therefore, implements viewport propagation logic in `StyleResolver` to ensure that `image-animation` values correctly apply to the root viewport. Note that it intentionally prevents propagation from the <body> element to the viewport, which aligns with the CSS Image Animation specification [1][2]. Additionally, by adding 'image_node_animation_info' to 'GraphicsContext::DrawImageTiled' and passing it through the related paint pipeline, the underlying graphics layer can now correctly resolve the animation state for tiled images (e.g., 'background-repeat'). [1] https://drafts.csswg.org/css-image-animation-1/#image-animation [2] w3c/csswg-drafts#13435 (comment) Bug: 429459566 Change-Id: I0f834d30e7567396bdd69cf8135b1be4098af6b3
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the 'image-animation' property is not correctly propagated
from the root element to the viewport, and so root backgrounds fail to
respect the animation control.
Therefore, implements viewport propagation logic in
StyleResolvertoensure that
image-animationvalues correctly apply to the rootviewport.
Note that it intentionally prevents propagation from the <body> element
to the viewport, which aligns with the CSS Image Animation specification
[1][2].
Additionally, by adding 'image_node_animation_info' to
'GraphicsContext::DrawImageTiled' and passing it through the related
paint pipeline, the underlying graphics layer can now correctly resolve
the animation state for tiled images (e.g., 'background-repeat').
[1] https://drafts.csswg.org/css-image-animation-1/#image-animation
[2] w3c/csswg-drafts#13435 (comment)
Bug: 429459566
Change-Id: I0f834d30e7567396bdd69cf8135b1be4098af6b3
Reviewed-on: https://chromium-review.googlesource.com/7763845
WPT-Export-Revision: a6b6b6ad84482b5e2c99751855b24346d5804b8e