Do proper snapshotting in TextOverflowPostLayoutSnapshot#58769
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Mar 26, 2026
Merged
Do proper snapshotting in TextOverflowPostLayoutSnapshot#58769chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
We never used the snapshotted value in TextOverflowPostLayoutSnapshot during layout, which meant we could be out of sync for the stored value and the previous used value for forced layouts. That again lead to invalidation issues. Instead use the snapshotted value during layout. Also added some documentation to the class. Bug: 495842549 Change-Id: I6589385f01294811e484a53d5771254f48c9f46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7698437 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1605344}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7698437
branch
from
f9002f7 to
1a5f8b5
Compare
wpt-pr-bot
approved these changes
Mar 26, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We never used the snapshotted value in TextOverflowPostLayoutSnapshot
during layout, which meant we could be out of sync for the stored value
and the previous used value for forced layouts. That again lead to
invalidation issues.
Instead use the snapshotted value during layout. Also added some
documentation to the class.
Bug: 495842549
Change-Id: I6589385f01294811e484a53d5771254f48c9f46a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7698437
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1605344}