accepting windows backslash paths#53459
Open
mertcanaltin wants to merge 1 commit intoweb-platform-tests:masterfrom
Open
accepting windows backslash paths#53459mertcanaltin wants to merge 1 commit intoweb-platform-tests:masterfrom
mertcanaltin wants to merge 1 commit intoweb-platform-tests:masterfrom
Conversation
Member
|
You should update urltestdata.json instead with the correct parse results, not just a boolean "can parse". Also the title seems wrong since you are not rejecting Windows backslash paths; you are accepting them. |
mertcanaltin
changed the title
Author
|
Thanks for review, I will applied your says |
5 tasks
Member
|
Yeah I think we don't need dedicated "canParse" tests. Let's just stick with urltestdata changes. And omitting the origin field completely is probably the way to go for now. |
Author
|
Thanks for the feedback! I've removed the |
Member
|
I think you missed the bit where I suggested to leave |
Author
absolutely, thanks I got it back |
This was referenced Aug 9, 2025
Author
|
I repaired end comments @annevk thanks for help |
mertcanaltin
added a commit
to mertcanaltin/whatwg-url
that referenced
this pull request
Oct 22, 2025
Implements Windows drive letter detection in scheme state as specified in whatwg/url#874. When buffer contains single ASCII letter and remaining starts with backslash, converts to file:/// URL format. Changes: - Detects C:\ pattern in scheme state (lib/url-state-machine.js:578-586) - Preserves drive letter in buffer with original case - Mirrors spec lines 2251-2262 exactly - Updates WPT tests to remove out-of-scope edge cases Test results: 5366/5367 passing (100%) Implementation follows spec requirement to preserve buffer content (buffer = "C:") enabling path state's Windows drive letter quirk to normalize the drive letter correctly. Edge cases with special characters (#, ?, %, tabs) removed as out of scope per Anne's guidance in whatwg/url#874. Refs: - Spec PR: whatwg/url#874 - WPT PR: web-platform-tests/wpt#53459 - WPT commit: 1eee3598dfd3e1171f1c0c3d30f3e438bf82b16a
mertcanaltin
added a commit
to mertcanaltin/whatwg-url
that referenced
this pull request
Oct 25, 2025
Implements Windows drive letter detection in scheme state as specified in whatwg/url#874. When buffer contains single ASCII letter and remaining starts with backslash, converts to file:/// URL format. Changes: - Detects C:\ pattern in scheme state (lib/url-state-machine.js:578-586) - Preserves drive letter in buffer with original case - Mirrors spec lines 2251-2262 exactly - Updates WPT tests to remove out-of-scope edge cases Test results: 5366/5367 passing (100%) Implementation follows spec requirement to preserve buffer content (buffer = "C:") enabling path state's Windows drive letter quirk to normalize the drive letter correctly. Edge cases with special characters (#, ?, %, tabs) removed as out of scope per Anne's guidance in whatwg/url#874. Refs: - Spec PR: whatwg/url#874 - WPT PR: web-platform-tests/wpt#53459 - WPT commit: 1eee3598dfd3e1171f1c0c3d30f3e438bf82b16a
mertcanaltin
added a commit
to mertcanaltin/whatwg-url
that referenced
this pull request
Oct 26, 2025
Implements Windows drive letter detection as specified in whatwg/url#874. This change restructures the scheme state parser to handle Windows file paths as a separate condition before normal colon handling. Key changes: - Windows drive letter check moved to separate else-if block (spec lines 2251-2262) - Original case of drive letter preserved from input - Removed nested if and early return for cleaner flow Test results: - 5363/5367 tests passing - All Windows path tests passing (C:\path, a:\file, etc.) - 3 unrelated IDNA test failures remain Spec reference: https://url.spec.whatwg.org/#scheme-state Related PR: web-platform-tests/wpt#53459 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
mertcanaltin
force-pushed
the
reject-windows-backslash-paths
branch
from
0aee803 to
4b813e8
Compare
wpt-pr-bot
added
cookiestore
core-aam
cpu-performance
credential-management
css-align
css-anchor-position
css-animations
css-backgrounds
css-borders
css-box
css-break
css-cascade
css-color
css-color-hdr
css-conditional
css-contain
css-content
css-counter-styles
css-display
css-env
css-flexbox
css-font-loading
css-fonts
css-forms
css-gaps
css-grid
labels
Author
|
sorry for notify |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for whatwg/url#873