fix: remove extra space after breaking change emoji#318
fix: remove extra space after breaking change emoji#318guoyangzhen wants to merge 2 commits intounjs:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdjusted spacing in the breaking-change warning prefix used by the markdown formatter: the emoji prefix now uses one trailing space instead of two; corresponding test snapshots were updated to match. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/markdown.ts`:
- Line 144: The commit message formatter now outputs a single space after the
warning emoji (it builds the string using (commit.isBreaking ? "⚠️ " : "")), so
update the test expectations that still expect two spaces; open the test file
test/git.test.ts and replace the inline snapshot strings containing "⚠️ " with
"⚠️ " (search for occurrences around the snapshot assertions) so the expected
snapshots match the new emoji spacing.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Fixes #309
The breaking change emoji had two spaces after it (
⚠️) instead of one (⚠️), causing an extra space in the generated changelog output.Summary by CodeRabbit