Skip to content

fix: remove extra space after breaking change emoji#318

Open
guoyangzhen wants to merge 2 commits intounjs:mainfrom
guoyangzhen:fix/breaking-change-emoji-space
Open

fix: remove extra space after breaking change emoji#318
guoyangzhen wants to merge 2 commits intounjs:mainfrom
guoyangzhen:fix/breaking-change-emoji-space

Conversation

@guoyangzhen
Copy link
Copy Markdown

@guoyangzhen guoyangzhen commented Mar 30, 2026

Fixes #309

The breaking change emoji had two spaces after it (⚠️ ) instead of one (⚠️ ), causing an extra space in the generated changelog output.

Summary by CodeRabbit

  • Style
    • Adjusted spacing in markdown for breaking-change notices (reduced extra space after the warning icon), improving consistency in generated commit entries.
  • Tests
    • Updated tests to match the revised breaking-change markdown spacing so snapshots and expected outputs remain aligned.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b06538bc-4095-47aa-aca8-ba22fcb94033

📥 Commits

Reviewing files that changed from the base of the PR and between 88ffc24 and bda41d0.

📒 Files selected for processing (1)
  • test/git.test.ts

📝 Walkthrough

Walkthrough

Adjusted spacing in the breaking-change warning prefix used by the markdown formatter: the emoji prefix now uses one trailing space instead of two; corresponding test snapshots were updated to match.

Changes

Cohort / File(s) Summary
Markdown formatting
src/markdown.ts
Change breaking-change prefix from "⚠️ " (two spaces) to "⚠️ " (one space).
Tests updated
test/git.test.ts
Updated expected Markdown snapshots to remove the extra space after the ⚠️ emoji in breaking-change examples.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tiny hop, a tidy trace,
I trimmed a space beside the face,
One emoji wink, one space to stay,
Now warnings tidy, bright as day. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing an extra space after the breaking change emoji in the markdown formatting.
Linked Issues check ✅ Passed The PR directly addresses issue #309 by changing the breaking change emoji from two spaces to one space in src/markdown.ts and updating corresponding test snapshots.
Out of Scope Changes check ✅ Passed All changes are scoped to fixing issue #309: the emoji spacing correction in src/markdown.ts and the necessary test snapshot updates.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/markdown.ts`:
- Line 144: The commit message formatter now outputs a single space after the
warning emoji (it builds the string using (commit.isBreaking ? "⚠️ " : "")), so
update the test expectations that still expect two spaces; open the test file
test/git.test.ts and replace the inline snapshot strings containing "⚠️  " with
"⚠️ " (search for occurrences around the snapshot assertions) so the expected
snapshots match the new emoji spacing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 566e478b-8067-41e6-a82d-b31a65b7f3ee

📥 Commits

Reviewing files that changed from the base of the PR and between 1721588 and 88ffc24.

📒 Files selected for processing (1)
  • src/markdown.ts

Comment thread src/markdown.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra space character after breaking change emoju (⚠️)

1 participant