Skip to content

feat: lookup Github username if token is available#155

Open
JohnCampionJr wants to merge 10 commits intounjs:mainfrom
JohnCampionJr:authors
Open

feat: lookup Github username if token is available#155
JohnCampionJr wants to merge 10 commits intounjs:mainfrom
JohnCampionJr:authors

Conversation

@JohnCampionJr
Copy link
Copy Markdown

🔗 Linked issue

#116

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Using @antfu's changelogithub as inspiration, I added this feature to changelogen.

If a GitHub token is available, it will retrieve usernames through the GitHub API. Otherwise, it returns the exact same author info as before.

Added tests with both a token and without a token.

Resolves #116

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@JohnCampionJr
Copy link
Copy Markdown
Author

I have no idea why the test is failing; it works here. Is the ungh API not available in CI?

Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work ❤️

Comment thread src/author.ts Outdated
Comment thread src/author.ts Outdated
Comment thread src/author.ts Outdated
Comment thread src/author.ts Outdated
@JohnCampionJr
Copy link
Copy Markdown
Author

@pi0 all set!

@JohnCampionJr
Copy link
Copy Markdown
Author

@pi0 any chance of getting this merged?

@marlondecol
Copy link
Copy Markdown

Hey! I believe this change would be very valuable and I’d really like to see it implemented. Let me know if there’s anything I can do to help!

@PKief
Copy link
Copy Markdown
Contributor

PKief commented Sep 21, 2025

@marlondecol @pi0 I've created a follow up PR which will resolve the username from the PR which is referenced in the commit references. This will also find the correct username of the users who don't have a public email address in github: #294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub username mentions for GitHub releases

5 participants