Conversation
|
NetBSD CDN is down but it's unrelated to this change, ready for review. |
There was a problem hiding this comment.
Looks great to me, but maybe hold off for a day in case @asomers gets the chance to take a look.
Also maybe update the commit/PR description to say it's migrating to GHA? From the quick read I assumed you were just deleting the job :)
| with: | ||
| release: ${{ matrix.release }} | ||
| usesh: true | ||
| mem: 4096 |
There was a problem hiding this comment.
What's wrong with the default memory?
| copyback: false | ||
| prepare: | | ||
| set -eux | ||
| export HOME=/tmp |
There was a problem hiding this comment.
This workflow isn't using cargo cache. It certainly isn't, since you set copyback: false. So you can delete this line.
| export HOME=/tmp |
| mem: 4096 | ||
| copyback: false | ||
| prepare: | | ||
| set -eux |
There was a problem hiding this comment.
Why the "-u" ?
There was a problem hiding this comment.
I think it's good practice to always set this in scripts. Expected nullable variables are rare enough to have :- on a case-by-case basis.
4 participants
Description
Fix #5052
The new GHA matrix should have the same workflow as Cirrus as possible.
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI