Fix string validation errors#1740
Merged
kfcampbell merged 4 commits intooctokit:mainfrom Apr 23, 2025
Merged
Conversation
Just came across this in the wild openSUSE/open-build-service#17535 Apparently sometimes the validation json is formated like that.
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
Contributor
Author
|
Anything I can do to push this forward? 🤠 |
kfcampbell
approved these changes
Apr 23, 2025
Contributor
kfcampbell
left a comment
kfcampbell
left a comment
There was a problem hiding this comment.
I've added a couple of additional test cases here and fixed the Rubocop error. I'll get this merged and released shortly.
Contributor
Author
|
Cheers Keegan 💐 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just came across this in the wild
openSUSE/open-build-service#17535
Apparently sometimes the validation json is formated like that.
Before the change?
Octokit::Error.response_error_summarycrashesAfter the change?
Octokit::Error.response_error_summarysucceedsPull request checklist
Does this introduce a breaking change?