Skip to content

fix(i18n): update language switch immediately without refresh #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BittuBarnwal7479 wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −2
Open

fix(i18n): update language switch immediately without refresh #2525

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7984140
feat: Fixed language switch so it updates immediately (no refresh)
invalid-email-address Apr 14, 2026
9b2c854
bug: fixed Settings nav icon rendering in header
invalid-email-address Apr 14, 2026
b0a3548
Merge branch 'main' into fix/header-nav-i18n-and-settings-icon
BittuBarnwal7479 Apr 14, 2026
4cd45c2
Revert "bug: fixed Settings nav icon rendering in header"
invalid-email-address Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/components/AppHeader.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const desktopLinks = computed<NavigationConfig>(() => [
name: 'Settings',
label: $t('nav.settings'),
to: { name: 'settings' },
keyshortcut: ',',
keyshortcut: 's',
type: 'link',
external: false,
iconClass: 'i-lucide:settings',
Expand Down Expand Up @@ -201,8 +201,8 @@ function handleSearchFocus() {
}

useShortcuts({
'c': () => ({ name: 'compare' }),
',': () => ({ name: 'settings' }),
c: () => ({ name: 'compare' }),
s: () => ({ name: 'settings' }),
})
</script>

Expand Down Expand Up @@ -316,7 +316,7 @@ useShortcuts({
class="border-none"
variant="button-secondary"
:to="link.to"
:aria-keyshortcuts="link.keyshortcut"
:classicon="link.iconClass"
>
{{ link.label }}
</LinkBase>
Expand Down
9 changes: 7 additions & 2 deletions app/pages/settings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ const setLocale: typeof setNuxti18nLocale = newLocale => {
settings.value.selectedLocale = newLocale
return setNuxti18nLocale(newLocale)
}

function handleLocaleChange(newLocale?: string) {
if (!newLocale) return
setLocale(newLocale)
}
</script>

<template>
Expand Down Expand Up @@ -244,8 +249,8 @@ const setLocale: typeof setNuxti18nLocale = newLocale => {
<SelectField
id="language-select"
:items="locales.map(loc => ({ label: loc.name ?? '', value: loc.code }))"
v-model="currentLocale"
@update:modelValue="setLocale($event as typeof currentLocale)"
:modelValue="currentLocale"
@update:modelValue="handleLocaleChange"
block
size="sm"
class="max-w-48"
Expand Down
Loading