feat(lib): allow to add custom storage#28
Open
va-stefanek wants to merge 1 commit intongneat:masterfrom
Open
Conversation
5e4efc4 to
b7883b8
Compare
Member
|
Thanks for the PR. Can you update the docs, please? |
b7883b8 to
1e1fe55
Compare
Author
|
@NetanelBasal Done. |
|
Any updates on this feature? This is very important! |
Author
|
@AdmilsonCossa I will try to complete this by the end of the week. |
|
@va-stefanek looking for your update sir :D |
1e1fe55 to
07dfcfe
Compare
Author
|
@NetanelBasal let me know if we are still interested in that feature, whether we should remove FORMS_MANAGER_SESSION_STORAGE_PROVIDER. I have pushed new changes with using @ngneat/storage Sorry everyone for the delay. |
|
ya I'm looking for this feature still waiting :D |
Member
|
@va-stefanek sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently we can only use localStorage as a persistence storage
Issue Number: #6
What is the new behavior?
We can use any persistence storage which extends proper interface
Does this PR introduce a breaking change?
Other information