workflows: pin dependencies

.github/dependabot.yml

@@ -0,0 +1,14 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    open-pull-requests-limit: 5
+    groups:
+      Github Actions updates:
+        applies-to: version-updates
+        dependency-type: production
+    schedule:
+      # Check for updates to GitHub Actions every week
+      day: "monday"
+      time: "09:00"
+      interval: "weekly"

.github/workflows/ci.yml

@@ -37,11 +37,11 @@ jobs:
     - name: Lint & test webapp
       run: cd focalboard; make webapp-ci
 
-    - name: set up golangci-lint
-      run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.64.8
-
-    - name: Lint & test server 
-      run: cd focalboard; make server-ci
+    - name: Run golangci-lint
+      uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20  # v9.2.0
+      with:
+        version: v2.8.0
+        working-directory: focalboard/server
 
   dist:
     uses: mattermost/actions-workflows/.github/workflows/plugin-dist-pr.yml@main

.github/workflows/codeql-analysis.yml

@@ -30,16 +30,16 @@ jobs:
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
-      uses: github/codeql-action/init@v3.28.9
+      uses: github/codeql-action/init@9e8d0789d4a0fa9ceb6b1738f7e269594bdd67f0  # v3.28.9
       with:
         languages: ${{ matrix.language }}
         debug: false
         config-file: ./.github/codeql/codeql-config.yml              
 
     # Autobuild attempts to build any compiled languages
     - name: Autobuild
-      uses: github/codeql-action/autobuild@v3.28.9
+      uses: github/codeql-action/autobuild@9e8d0789d4a0fa9ceb6b1738f7e269594bdd67f0  # v3.28.9
 
     # Perform Analysis
     - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v3.28.9
+      uses: github/codeql-action/analyze@9e8d0789d4a0fa9ceb6b1738f7e269594bdd67f0  # v3.28.9

.github/workflows/lint-server.yml

@@ -34,9 +34,9 @@ jobs:
       - uses: actions/setup-go@3041bf56c941b39c61721a86cd11f3bb1338122a # v5.2.0
         with:
           go-version-file: focalboard/go.mod
-      - name: set up golangci-lint
-        run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.64.8
-      - name: lint
-        run: |
-          cd focalboard
-          make server-lint
+
+      - name: Run golangci-lint
+        uses: golangci/golangci-lint-action@1e7e51e771db61008b38414a730f564565cf7c20  # v9.2.0
+        with:
+          version: v2.8.0
+          working-directory: focalboard/server

server/.golangci.yml

@@ -1,80 +1,89 @@
+version: "2"
 run:
-  timeout: 5m
   modules-download-mode: readonly
-
-linters-settings:
-  gofmt:
-    simplify: true
-  goimports:
-    local-prefixes: github.com/mattermost/mattermost-starter-template
-  golint:
-    min-confidence: 0
-  govet:
-    enable-all: true
-    disable:
-      - fieldalignment
-  misspell:
-    locale: US
-  lll:
-    line-length: 150
-  revive:
-    enableAllRules: true
-    rules:
-      - name: exported
-        disabled: true
-
 linters:
-  disable-all: true
-  settings:
-    govet:
-      enable:
-        - shadow
+  default: none
   enable:
-    - gofmt
-    - goimports
-    - ineffassign
-    - unparam
-    - govet
+    - asciicheck
     - bodyclose
+    - copyloopvar
+    - dogsled
     - durationcheck
+    - err113
     - errorlint
     - exhaustive
-    - copyloopvar
-    - gosec
-    - makezero
-    - staticcheck
-    - prealloc
-    - asciicheck
-    - dogsled
     - gocritic
+    - gocyclo
     - godot
-    - err113
     - goheader
-    - revive
-    - nakedret
     - gomodguard
     - goprintffuncname
-    - gosimple
+    - gosec
+    - govet
+    - ineffassign
+    - makezero
     - misspell
+    - nakedret
     - nolintlint
-    - typecheck
+    - prealloc
+    - revive
+    - staticcheck
     - unconvert
+    - unparam
     - unused
     - whitespace
-    - gocyclo
-
-issues:
-  exclude-files:
-    - product/boards_product.go
-    - services/store/sqlstore/migrations
-  exclude-rules:
-    - path: server/manifest.go
-      linters:
-        - unused
-    - path: server/configuration.go
-      linters:
-        - unused
-    - path: _test\.go
-      linters:
-        - bodyclose
-        - scopelint # https://github.com/kyoh86/scopelint/issues/4
+  settings:
+    govet:
+      disable:
+        - fieldalignment
+      enable-all: true
+    lll:
+      line-length: 150
+    misspell:
+      locale: US
+    revive:
+      rules:
+        - name: exported
+          disabled: true
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - unused
+        path: server/manifest.go
+      - linters:
+          - unused
+        path: server/configuration.go
+      - linters:
+          - bodyclose
+          - scopelint  # https://github.com/kyoh86/scopelint/issues/4
+        path: _test\.go
+    paths:
+      - product/boards_product.go
+      - services/store/sqlstore/migrations
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    gofmt:
+      simplify: true
+    goimports:
+      local-prefixes:
+        - github.com/mattermost/mattermost-starter-template
+  exclusions:
+    generated: lax
+    paths:
+      - product/boards_product.go
+      - services/store/sqlstore/migrations
+      - third_party$
+      - builtin$
+      - examples$

server/integrationtests/board_test.go

@@ -572,7 +572,7 @@ func TestSearchBoards(t *testing.T) {
 				boards, resp := tc.Client.SearchBoardsForTeam(teamID, tc.Term)
 				th.CheckOK(resp)
 
-				boardIDs := []string{}
+				boardIDs := make([]string, 0, len(boards))
 				for _, board := range boards {
 					boardIDs = append(boardIDs, board.ID)
 				}
@@ -2065,7 +2065,7 @@ func TestDuplicateBoard(t *testing.T) {
 		for _, categoryBoard := range userCategoryBoards {
 			for _, boardMetadata := range categoryBoard.BoardMetadata {
 				if boardMetadata.BoardID == duplicateBoard.ID {
-					duplicateBoardCategoryID = categoryBoard.Category.ID
+					duplicateBoardCategoryID = categoryBoard.ID
 				}
 			}
 		}

server/integrationtests/pluginteststore.go

@@ -185,8 +185,8 @@ func (s *PluginTestStore) GetUsersByTeam(teamID string, asGuestID string, showEm
 		}, nil
 	}
 
-	switch {
-	case teamID == s.testTeam.ID:
+	switch teamID {
+	case s.testTeam.ID:
 		return []*model.User{
 			s.users["team-member"],
 			s.users["viewer"],
@@ -195,15 +195,15 @@ func (s *PluginTestStore) GetUsersByTeam(teamID string, asGuestID string, showEm
 			s.users["admin"],
 			s.users["guest"],
 		}, nil
-	case teamID == s.otherTeam.ID:
+	case s.otherTeam.ID:
 		return []*model.User{
 			s.users["team-member"],
 			s.users["viewer"],
 			s.users["commenter"],
 			s.users["editor"],
 			s.users["admin"],
 		}, nil
-	case teamID == s.emptyTeam.ID:
+	case s.emptyTeam.ID:
 		return []*model.User{}, nil
 	}
 	return nil, errTestStore
@@ -275,22 +275,24 @@ func (s *PluginTestStore) SearchUserChannels(teamID, userID, query string) ([]*m
 }
 
 func (s *PluginTestStore) GetChannel(teamID, channel string) (*mmModel.Channel, error) {
-	if channel == "valid-channel-id" {
+	switch channel {
+	case "valid-channel-id":
 		return &mmModel.Channel{
 			TeamId:      teamID,
 			Id:          "valid-channel-id",
 			DisplayName: "Valid Channel",
 			Name:        "valid-channel",
 		}, nil
-	} else if channel == "valid-channel-id-2" {
+	case "valid-channel-id-2":
 		return &mmModel.Channel{
 			TeamId:      teamID,
 			Id:          "valid-channel-id-2",
 			DisplayName: "Valid Channel 2",
 			Name:        "valid-channel-2",
 		}, nil
+	default:
+		return nil, errTestStore
 	}
-	return nil, errTestStore
 }
 
 func (s *PluginTestStore) SearchBoardsForUser(term string, field model.BoardSearchField, userID string, includePublicBoards bool) ([]*model.Board, error) {

server/model/properties_test.go

@@ -15,19 +15,20 @@ import (
 type MockResolver struct{}
 
 func (r MockResolver) GetUserByID(userID string) (*User, error) {
-	if userID == "user_id_1" {
+	switch userID {
+	case "user_id_1":
 		return &User{
 			ID:       "user_id_1",
 			Username: "username_1",
 		}, nil
-	} else if userID == "user_id_2" {
+	case "user_id_2":
 		return &User{
 			ID:       "user_id_2",
 			Username: "username_2",
 		}, nil
+	default:
+		return nil, nil
 	}
-
-	return nil, nil
 }
 
 func Test_parsePropertySchema(t *testing.T) {

server/services/store/sqlstore/data_migrations_test.go

@@ -60,7 +60,7 @@ func TestGetBlocksWithSameID(t *testing.T) {
 
 	// we process the found blocks to remove extra information and be
 	// able to compare both expected and found sets
-	foundBlocks := []*model.Block{}
+	foundBlocks := make([]*model.Block, 0, len(blocks))
 	for _, foundBlock := range blocks {
 		foundBlocks = append(foundBlocks, &model.Block{ID: foundBlock.ID, BoardID: foundBlock.BoardID})
 	}

server/services/store/storetests/boards.go

@@ -942,7 +942,7 @@ func testSearchBoardsForUser(t *testing.T, store store.Store) {
 			boards, err := store.SearchBoardsForUser(tc.Term, tc.SearchField, tc.UserID, tc.IncludePublic)
 			require.NoError(t, err)
 
-			boardIDs := []string{}
+			boardIDs := make([]string, 0, len(boards))
 			for _, board := range boards {
 				boardIDs = append(boardIDs, board.ID)
 			}

server/services/store/storetests/boards_and_blocks.go

@@ -67,12 +67,12 @@ func testCreateBoardsAndBlocks(t *testing.T, store store.Store) {
 		require.Len(t, bab.Boards, 3)
 		require.Len(t, bab.Blocks, 2)
 
-		boardIDs := []string{}
+		boardIDs := make([]string, 0, len(bab.Boards))
 		for _, board := range bab.Boards {
 			boardIDs = append(boardIDs, board.ID)
 		}
 
-		blockIDs := []string{}
+		blockIDs := make([]string, 0, len(bab.Blocks))
 		for _, block := range bab.Blocks {
 			blockIDs = append(blockIDs, block.ID)
 		}
@@ -101,20 +101,20 @@ func testCreateBoardsAndBlocks(t *testing.T, store store.Store) {
 		require.Len(t, bab.Blocks, 2)
 		require.Len(t, members, 3)
 
-		boardIDs := []string{}
+		boardIDs := make([]string, 0, len(bab.Boards))
 		for _, board := range bab.Boards {
 			boardIDs = append(boardIDs, board.ID)
 		}
 
-		blockIDs := []string{}
+		blockIDs := make([]string, 0, len(bab.Blocks))
 		for _, block := range bab.Blocks {
 			blockIDs = append(blockIDs, block.ID)
 		}
 
 		require.ElementsMatch(t, []string{"board-id-4", "board-id-5", "board-id-6"}, boardIDs)
 		require.ElementsMatch(t, []string{"block-id-3", "block-id-4"}, blockIDs)
 
-		memberBoardIDs := []string{}
+		memberBoardIDs := make([]string, 0, len(members))
 		for _, member := range members {
 			require.Equal(t, userID, member.UserID)
 			memberBoardIDs = append(memberBoardIDs, member.BoardID)

server/services/store/storetests/compliance.go

@@ -109,7 +109,7 @@ func testGetBoardsComplianceHistory(t *testing.T, store store.Store) {
 
 	boardsTeam1 := createTestBoards(t, store, team1, testUserID, 11)
 	boardsTeam2 := createTestBoards(t, store, team2, testUserID, 7)
-	boardsAdded := make([]*model.Board, 0)
+	boardsAdded := make([]*model.Board, 0, len(boardsTeam1)+len(boardsTeam2))
 	boardsAdded = append(boardsAdded, boardsTeam1...)
 	boardsAdded = append(boardsAdded, boardsTeam2...)
 

server/web/webserver_test.go

@@ -93,9 +93,9 @@ func Test_NewServer(t *testing.T) {
 			require.Equal(t, test.logger, ws.logger, "logger pointer does not match")
 
 			if test.localOnly == true {
-				require.Equal(t, test.expectedServerAddr, ws.Server.Addr, "localhost address not as matching!")
+				require.Equal(t, test.expectedServerAddr, ws.Addr, "localhost address not as matching!")
 			} else {
-				require.Equal(t, test.expectedServerAddr, ws.Server.Addr, "server address not matching!")
+				require.Equal(t, test.expectedServerAddr, ws.Addr, "server address not matching!")
 			}
 		})
 	}