Call previous error handler at end of QM_Collector_PHP_Errors::error_handler()#759
Draft
BrianHenryIE wants to merge 3 commits intojohnbillion:developfrom
Draft
Call previous error handler at end of QM_Collector_PHP_Errors::error_handler()#759BrianHenryIE wants to merge 3 commits intojohnbillion:developfrom
QM_Collector_PHP_Errors::error_handler()#759BrianHenryIE wants to merge 3 commits intojohnbillion:developfrom
Conversation
Owner
|
Thanks for the PR! I'll need to investigate the wider impact of this change. |
Author
|
I think I need to move the call to the previous error handler to before the filter so it is always run. Currently the filter could short-circuit and return true without calling it. E.g. here is an error handler which logs the error if it's relevant to the plugin, I don't think it's Query Monitor's place to decide not run this code: bh-wp-logger I'm having trouble spinning up the test environment (although I obviously had it running already). I'll try again soon. |
Contributor
|
This might be fixed by #938. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an MU plugin to mute deprecation warnings. With Query Monitor active, its error handler is never run.
The common pattern is to save the return value of
set_error_handler()to an instance variable, as you have done with$previous_error_handler, and then to call it at the end of the new error handler, if it exists. I have added the latter part.https://www.php.net/manual/en/function.set-error-handler.php#123459