Skip to content

Overridable added to tabs in community header search app#2307

Open
Ducica wants to merge 3 commits intoinveniosoftware:masterfrom
oarepo:oarepo-contribution-community-header
Open

Overridable added to tabs in community header search app#2307
Ducica wants to merge 3 commits intoinveniosoftware:masterfrom
oarepo:oarepo-contribution-community-header

Conversation

@Ducica
Copy link
Copy Markdown
Contributor

@Ducica Ducica commented Apr 9, 2026

❤️ Thank you for your contribution!

Description

A few fixes related to community header. I've split it into logically related commits, so that you can more easily reject or accept some. The fixes are:

  1. ability to pass search app config to community header as a prop (imo this was probably simply forgotten when component was originally written).
  2. Modal close button not working (ditto).
  3. The third change is the largest. We need a good way to override those tabs, because somewhere we could have different number of tabs (1 or 3). The use case for us, is that we have some repositories where it is much stricter who can submit to which community, so we require some flexibility here. I've decided to make the overrides passed to search app via prop, and contained to the component, instead of pasting overrideStore.getAll to the overridable provider, as I thought this would make it cleaner and contained to the component itself. Also in some repositories, we could have 5 or more forms, and using global override store is not a good idea for such a use case.

Please let us know what you think.

Thanks,

Dusan S

textAlign="left"
floated="left"
className="pt-0 pl-0"
<Overridable
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Container should not be conditional (rendered only when mycommunities enabled)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right my bad

@Ducica Ducica force-pushed the oarepo-contribution-community-header branch from e9ddf64 to 089ce3d Compare April 9, 2026 09:45
@Ducica Ducica changed the title Oarepo contribution community header Overridable added to tabs in community header search app Apr 9, 2026
@Ducica Ducica added this to v14 Apr 9, 2026
@Ducica Ducica moved this to Triage in v14 Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants