Fix: show chapter title in lesson view#2312
Open
aditya-patwa18 wants to merge 60 commits intofrappe:mainfrom
Open
Fix: show chapter title in lesson view#2312aditya-patwa18 wants to merge 60 commits intofrappe:mainfrom
aditya-patwa18 wants to merge 60 commits intofrappe:mainfrom
Conversation
revert: change switches into checkbox
chore: update POT file
ci(build): add payments repository to APPS_JSON
fix: misc issues
…kout fix: allow zero amount checkout with coupons
fix: prevent xss in meta data
fix: improved list for assignments and programming exercises
fix: misc issues
fix: prevent path traversal in scorm file
chore: update POT file
refactor: jobs and certified participants view
feat: rtl support
fix: loading state on batch details, student enrollment by admin
lms
|
||||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 00m 29s |
| Commit |
|
| Committer | pull[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
1
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
lms
|
||||||||||||||||||||||||||||||
| Project |
lms
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 00m 34s |
| Commit |
|
| Committer | Raizaaa |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
1
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Contributor
|
Could you add a detailed description with before and after? Because if you mean inside the lesson editor, it is a deliberate design choice since in normal mode, you can see the chapter name in breadcrumbs. |
Author
|
Thanks for pointing that out. What I noticed while using the lesson view is that the chapter name is technically present in the breadcrumbs, but it’s easy to overlook when you're focused on the lesson content. Also, there’s a small inconsistency — in Zen mode, the chapter name appears near the title, but in normal mode it doesn’t. Before:
After:
The idea was just to make the context of the lesson clearer without changing how navigation works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where the chapter title was only visible in Zen mode.
The chapter and course title are now displayed consistently in the lesson view, making it easier for users to understand the context of the lesson.