fix(template-no-passed-in-event-handlers): align event list and ignore config with upstream

- Remove mouseMove, mouseEnter, mouseLeave from event list (not in upstream)
- Use bare names (without @) in ignore config for angle bracket invocations
- Remove unnecessary PascalCase gate on ElementNode visitor

Author: johanrd

lib/rules/template-no-passed-in-event-handlers.js

@@ -12,9 +12,6 @@ const EMBER_EVENTS = new Set([
   'contextMenu',
   'click',
   'doubleClick',
-  'mouseMove',
-  'mouseEnter',
-  'mouseLeave',
   'focusIn',
   'focusOut',
   'submit',
@@ -77,10 +74,19 @@ module.exports = {
 
     return {
       GlimmerElementNode(node) {
-        // Only check component invocations (PascalCase)
-        if (!/^[A-Z]/.test(node.tag)) {
+        // Only check component invocations. In GTS, dashed tags like <my-button>
+        // are HTML (imports can't have dashes); lowercase non-dashed tags are
+        // HTML. Components are PascalCase, @-prefixed args, this.-prefixed
+        // references, or dot-paths (re-exports).
+        const isComponent =
+          /^[A-Z]/.test(node.tag) ||
+          node.tag.startsWith('@') ||
+          node.tag.startsWith('this.') ||
+          node.tag.includes('.');
+        if (!isComponent) {
           return;
         }
+
         // Skip built-in Input/Textarea
         if (node.tag === 'Input' || node.tag === 'Textarea') {
           return;
@@ -98,8 +104,8 @@ module.exports = {
           }
           const argName = attr.name.slice(1);
 
-          // Check ignore config
-          if (ignoredAttrs.includes(attr.name)) {
+          // Check ignore config (use bare name without @)
+          if (ignoredAttrs.includes(argName)) {
             continue;
           }
 

tests/lib/rules/template-no-passed-in-event-handlers.js

@@ -35,6 +35,15 @@ ruleTester.run('template-no-passed-in-event-handlers', rule, {
     '<template><Foo @random={{true}} /></template>',
     '<template><Input @click={{this.handleClick}} /></template>',
     '<template><Textarea @click={{this.handleClick}} /></template>',
+
+    // HTML elements are not checked (in GTS <my-button> is HTML, not a component)
+    '<template><my-button @click={{this.handleClick}} /></template>',
+    '<template><custom-el @submit={{this.handleSubmit}} /></template>',
+
+    // mouseMove/mouseEnter/mouseLeave are NOT in upstream's event list
+    '<template><Foo @mouseMove={{this.handleMove}} /></template>',
+    '<template><Foo @mouseEnter={{this.handleEnter}} /></template>',
+    '<template><Foo @mouseLeave={{this.handleLeave}} /></template>',
     '<template>{{foo}}</template>',
     '<template>{{foo onClick=this.handleClick}}</template>',
     '<template>{{foo onclick=this.handleClick}}</template>',
@@ -48,11 +57,11 @@ ruleTester.run('template-no-passed-in-event-handlers', rule, {
     // ignore option — angle bracket invocation
     {
       code: '<template><Foo @click={{this.handleClick}} /></template>',
-      options: [{ ignore: { Foo: ['@click'] } }],
+      options: [{ ignore: { Foo: ['click'] } }],
     },
     {
       code: '<template><Foo @click={{this.handleClick}} @submit={{this.handleSubmit}} /></template>',
-      options: [{ ignore: { Foo: ['@click', '@submit'] } }],
+      options: [{ ignore: { Foo: ['click', 'submit'] } }],
     },
 
     // ignore option — curly invocation
@@ -82,25 +91,33 @@ ruleTester.run('template-no-passed-in-event-handlers', rule, {
       errors: [{ messageId: 'unexpected' }],
     },
     {
-      code: `<template>
-        <CustomButton @mouseEnter={{this.handleHover}} />
-      </template>`,
+      code: '<template><Foo @click={{this.handleClick}} /></template>',
       output: null,
       errors: [{ messageId: 'unexpected' }],
     },
-
     {
-      code: '<template><Foo @click={{this.handleClick}} /></template>',
+      code: '<template><Foo @keyPress={{this.handleClick}} /></template>',
       output: null,
       errors: [{ messageId: 'unexpected' }],
     },
     {
-      code: '<template><Foo @keyPress={{this.handleClick}} /></template>',
+      code: '<template><Foo @submit={{this.handleClick}} /></template>',
       output: null,
       errors: [{ messageId: 'unexpected' }],
     },
+    // Non-PascalCase component forms: this.-prefixed, @-prefixed, dot-path
     {
-      code: '<template><Foo @submit={{this.handleClick}} /></template>',
+      code: '<template><this.MyComponent @click={{this.handleClick}} /></template>',
+      output: null,
+      errors: [{ messageId: 'unexpected' }],
+    },
+    {
+      code: '<template><@someComponent @click={{this.handleClick}} /></template>',
+      output: null,
+      errors: [{ messageId: 'unexpected' }],
+    },
+    {
+      code: '<template><ns.Widget @submit={{this.handleSubmit}} /></template>',
       output: null,
       errors: [{ messageId: 'unexpected' }],
     },
@@ -124,14 +141,14 @@ ruleTester.run('template-no-passed-in-event-handlers', rule, {
     {
       code: '<template><Bar @click={{this.handleClick}} /></template>',
       output: null,
-      options: [{ ignore: { Foo: ['@click'] } }],
+      options: [{ ignore: { Foo: ['click'] } }],
       errors: [{ messageId: 'unexpected' }],
     },
     // ignore option — only ignores specified attrs (angle bracket)
     {
       code: '<template><Foo @submit={{this.handleSubmit}} /></template>',
       output: null,
-      options: [{ ignore: { Foo: ['@click'] } }],
+      options: [{ ignore: { Foo: ['click'] } }],
       errors: [{ messageId: 'unexpected' }],
     },
     // ignore option — only ignores specified component (curly)
@@ -183,11 +200,11 @@ hbsRuleTester.run('template-no-passed-in-event-handlers', rule, {
     // ignore option — angle bracket invocation
     {
       code: '<Foo @click={{this.handleClick}} />',
-      options: [{ ignore: { Foo: ['@click'] } }],
+      options: [{ ignore: { Foo: ['click'] } }],
     },
     {
       code: '<Foo @click={{this.handleClick}} @submit={{this.handleSubmit}} />',
-      options: [{ ignore: { Foo: ['@click', '@submit'] } }],
+      options: [{ ignore: { Foo: ['click', 'submit'] } }],
     },
 
     // ignore option — curly invocation
@@ -266,14 +283,14 @@ hbsRuleTester.run('template-no-passed-in-event-handlers', rule, {
     {
       code: '<Bar @click={{this.handleClick}} />',
       output: null,
-      options: [{ ignore: { Foo: ['@click'] } }],
+      options: [{ ignore: { Foo: ['click'] } }],
       errors: [{ messageId: 'unexpected' }],
     },
     // ignore option — only ignores specified attrs (angle bracket)
     {
       code: '<Foo @submit={{this.handleSubmit}} />',
       output: null,
-      options: [{ ignore: { Foo: ['@click'] } }],
+      options: [{ ignore: { Foo: ['click'] } }],
       errors: [{ messageId: 'unexpected' }],
     },
     // ignore option — only ignores specified component (curly)