Merge pull request #2650 from johanrd/post-merge-review/no-quoteless-attributes

Post merge-review: Fix `template-no-quoteless-attributes` false positive on quoted values

Author: NullVoxPopuli

lib/rules/template-no-quoteless-attributes.js

@@ -21,28 +21,27 @@ module.exports = {
     },
   },
   create(context) {
+    const sourceCode = context.sourceCode;
     return {
       GlimmerAttrNode(node) {
-        // Check if attribute has text value without quotes
-        if (node.value?.type === 'GlimmerTextNode' && !/^["']/.test(node.value.chars)) {
-          const sourceCode = context.sourceCode;
-          const attrText = sourceCode.getText(node);
+        if (node.value?.type !== 'GlimmerTextNode') {
+          return;
+        }
 
-          // If value looks unquoted (no = or =value without quotes)
-          if (/=\s*[^"'{]/.test(attrText)) {
-            const type = node.name?.startsWith('@') ? 'Argument' : 'Attribute';
-            context.report({
-              node,
-              messageId: 'missing',
-              data: { type, name: node.name },
-              fix(fixer) {
-                const valueText = node.value.chars;
-                const replacementText = `${node.name}="${valueText}"`;
-                return fixer.replaceText(node, replacementText);
-              },
-            });
-          }
+        const valueSource = sourceCode.getText(node.value);
+        if (valueSource.length === 0 || valueSource[0] === '"' || valueSource[0] === "'") {
+          return;
         }
+
+        const type = node.name?.startsWith('@') ? 'Argument' : 'Attribute';
+        context.report({
+          node,
+          messageId: 'missing',
+          data: { type, name: node.name },
+          fix(fixer) {
+            return fixer.replaceText(node, `${node.name}="${node.value.chars}"`);
+          },
+        });
       },
     };
   },

tests/lib/rules/template-no-quoteless-attributes.js

@@ -17,6 +17,7 @@ ruleTester.run('template-no-quoteless-attributes', rule, {
     '<template><SomeThing ...attributes /></template>',
     '<template><div></div></template>',
     '<template><input disabled></template>',
+    '<template><div data-x="foo=bar"></div></template>',
   ],
   invalid: [
     {
@@ -57,6 +58,7 @@ hbsRuleTester.run('template-no-quoteless-attributes', rule, {
     '<SomeThing ...attributes />',
     '<div></div>',
     '<input disabled>',
+    '<div data-x="foo=bar"></div>',
   ],
   invalid: [
     {