Skip to content

chore(angular-virtual): proper angular 19#1158

Draft
benjavicente wants to merge 5 commits intoTanStack:mainfrom
benjavicente:angular-19
Draft

chore(angular-virtual): proper angular 19#1158
benjavicente wants to merge 5 commits intoTanStack:mainfrom
benjavicente:angular-19

Conversation

@benjavicente
Copy link
Copy Markdown

🎯 Changes

  • Upgrades the adapter to Angular +19. Angular 19 is the latest angular version with LTS.
  • Updates the implementation to use computed and linked signals instead of the lazy signal approach. This will make it possible to alias fields of the returned value, like items = this.rowVirtualizer.getVirtualItems.
  • Use vite as a bundler for angular since the package does not need any Angular compilation.

About #1096 and #1109, I couldn't replicate the issue with the latest version of virtual. With this upgrade to Angular 19, no effect could trigger directly set a value to a signal.

Pending:

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Align angular-virtual and Angular example dependencies with Angular 19 and update lockfile/docs to match.
Adopt Angular 19 signal primitives in the adapter/proxy implementation to improve lazy initialization and reactive tracking behavior.
Replace ng-packagr build artifacts/config with Vite library outputs and update package exports/scripts for ESM+CJS distribution.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c1196617-9729-462f-9fbc-05a0b3b5e892

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant