SA1313: Adding features and tests.#3892
Open
azarasi3 wants to merge 3 commits intoDotNetAnalyzers:masterfrom
Open
SA1313: Adding features and tests.#3892azarasi3 wants to merge 3 commits intoDotNetAnalyzers:masterfrom
azarasi3 wants to merge 3 commits intoDotNetAnalyzers:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3892 +/- ##
========================================
Coverage 97.44% 97.45%
========================================
Files 926 932 +6
Lines 110283 110571 +288
Branches 3319 3328 +9
========================================
+ Hits 107467 107758 +291
+ Misses 1847 1845 -2
+ Partials 969 968 -1 🚀 New features to boost your workflow:
|
Remove unused method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2974 SA1313: Parameter '__' must begin with lower-case letter.
Support for parameter names containing only '_'
The issue with lambda expression parameter names can be resolved by apply the following three options:
A compromise between IDE0060 and SA1313
Although it was decided not to fix it in #2599, since there is an exception rule for _ in SA1313, we think that it can be resolved by allowing parameters starting with _ as an exception when they are unused, in response to IDE0060 in SA1313.
However, to prioritize simple code, explicit discarding is not allowed.