fix: improve publishing information spacing#733
fix: improve publishing information spacing#733TahaKhan998 wants to merge 1 commit intoCERNDocumentServer:masterfrom
Conversation
91367cd to
0f5c05c
Compare
zubeydecivelek
left a comment
There was a problem hiding this comment.
Just a small question: is there any reason this styling is added in cds-rdm instead of invenio-app-rdm?
I added it in cds-rdm since this is a CDS-specific styling adjustment (spacing and text wrapping) applied thourgh theme override and does not modify any shared component or template in invenio-app-rdm. |
palkerecsenyi
left a comment
There was a problem hiding this comment.
Looks good! Regarding @zubeydecivelek's comment and your reply, just to clarify, does the new layout work okay without this CSS? Thanks!
| } | ||
|
|
||
| /* Add vertical spacing between Journal / Imprint / Thesis on small screens */ | ||
| @media only screen and (max-width: 767px) { |
There was a problem hiding this comment.
Nit: isn't it normally 768px?
There was a problem hiding this comment.
yes, it should be 768px. I'll update it.
Without the additional CSS the long metadata values overflow the container and break the layout on smaller screens. Without the CSS fix:
With the CSS fix applied:
The added CSS ensures long strings wrap correctly using overflow-wrap / word-break, which prevents the layout from breaking. |
Thanks, so does this mean it would be useful to add them on the InvenioRDM level instead of the CDS level as @zubeydecivelek suggested? |
Thanks for the feedback! I’ve created a new PR with the changes applied at the InvenioRDM level: inveniosoftware/invenio-app-rdm#3371 Shall we review that one instead and close this PR? |
|
I think you can close this PR, thanks! |




Description
Changes include:
These adjustments improve readability and prevent layout issues when fields contain very long values.
Related PR
Depends on:
inveniosoftware/invenio-rdm-records#2268
inveniosoftware/invenio-app-rdm#3362