Skip to content

fix: improve publishing information spacing#733

Closed
TahaKhan998 wants to merge 1 commit intoCERNDocumentServer:masterfrom
TahaKhan998:fix/publishing-info-spacing
Closed

fix: improve publishing information spacing#733
TahaKhan998 wants to merge 1 commit intoCERNDocumentServer:masterfrom
TahaKhan998:fix/publishing-info-spacing

Conversation

@TahaKhan998
Copy link
Copy Markdown

@TahaKhan998 TahaKhan998 commented Mar 11, 2026

Description

Changes include:

  • Adding left margin to the publishing info grid for better alignment
  • Introducing vertical spacing between sections on small screens
  • Allowing long strings (e.g. identifiers or long titles) to wrap properly to prevent overflow

These adjustments improve readability and prevent layout issues when fields contain very long values.

Related PR

Depends on:
inveniosoftware/invenio-rdm-records#2268
inveniosoftware/invenio-app-rdm#3362

@TahaKhan998 TahaKhan998 force-pushed the fix/publishing-info-spacing branch from 91367cd to 0f5c05c Compare March 11, 2026 12:53
@palkerecsenyi palkerecsenyi self-requested a review March 16, 2026 08:58
Copy link
Copy Markdown
Contributor

@zubeydecivelek zubeydecivelek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small question: is there any reason this styling is added in cds-rdm instead of invenio-app-rdm?

@TahaKhan998
Copy link
Copy Markdown
Author

Just a small question: is there any reason this styling is added in cds-rdm instead of invenio-app-rdm?

I added it in cds-rdm since this is a CDS-specific styling adjustment (spacing and text wrapping) applied thourgh theme override and does not modify any shared component or template in invenio-app-rdm.

Copy link
Copy Markdown
Member

@palkerecsenyi palkerecsenyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Regarding @zubeydecivelek's comment and your reply, just to clarify, does the new layout work okay without this CSS? Thanks!

}

/* Add vertical spacing between Journal / Imprint / Thesis on small screens */
@media only screen and (max-width: 767px) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: isn't it normally 768px?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it should be 768px. I'll update it.

@TahaKhan998
Copy link
Copy Markdown
Author

Looks good! Regarding @zubeydecivelek's comment and your reply, just to clarify, does the new layout work okay without this CSS? Thanks!

Without the additional CSS the long metadata values overflow the container and break the layout on smaller screens.

Without the CSS fix:

image

With the CSS fix applied:

image

The added CSS ensures long strings wrap correctly using overflow-wrap / word-break, which prevents the layout from breaking.

@palkerecsenyi
Copy link
Copy Markdown
Member

Looks good! Regarding @zubeydecivelek's comment and your reply, just to clarify, does the new layout work okay without this CSS? Thanks!

Without the additional CSS the long metadata values overflow the container and break the layout on smaller screens.

Without the CSS fix:
image

With the CSS fix applied:
image

The added CSS ensures long strings wrap correctly using overflow-wrap / word-break, which prevents the layout from breaking.

Thanks, so does this mean it would be useful to add them on the InvenioRDM level instead of the CDS level as @zubeydecivelek suggested?

@TahaKhan998
Copy link
Copy Markdown
Author

Looks good! Regarding @zubeydecivelek's comment and your reply, just to clarify, does the new layout work okay without this CSS? Thanks!

Without the additional CSS the long metadata values overflow the container and break the layout on smaller screens.
Without the CSS fix:
image
With the CSS fix applied:
image
The added CSS ensures long strings wrap correctly using overflow-wrap / word-break, which prevents the layout from breaking.

Thanks, so does this mean it would be useful to add them on the InvenioRDM level instead of the CDS level as @zubeydecivelek suggested?

Thanks for the feedback!

I’ve created a new PR with the changes applied at the InvenioRDM level: inveniosoftware/invenio-app-rdm#3371

Shall we review that one instead and close this PR?

@zubeydecivelek
Copy link
Copy Markdown
Contributor

I think you can close this PR, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants