Fix G204: replace os/exec with utilexec to address command injection warnings#148
Open
Fix G204: replace os/exec with utilexec to address command injection warnings#148
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors command execution in the status collector and auth provider to use k8s.io/utils/exec (utilexec) instead of os/exec, aiming to eliminate gosec G204 findings and enable easier mocking via an injected exec interface.
Changes:
- Added a
utilexec.Interfacefield tostatus.Collectorandauth.AuthProvider, defaulting toutilexec.New()in constructors. - Updated status command execution to call
c.exec.CommandContext(...)instead ofexec.CommandContext(...). - Updated Azure CLI invocation to use
a.exec.CommandContext(...)and switched interactive stdio wiring toSetStdin/SetStdout/SetStderr.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/status/collector.go | Introduces utilexec.Interface on Collector and routes runCommand through it. |
| pkg/auth/auth.go | Introduces utilexec.Interface on AuthProvider and updates Azure CLI command creation + interactive stdio setup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg/status/collector.goandpkg/auth/auth.goto usek8s.io/utils/exec(utilexec) instead ofos/execdirectly, eliminating gosec G204 (subprocess launched with variable) findings.utilexec.InterfaceintoCollectorandAuthProviderstructs, improving testability via dependency injection.Resolves https://github.com/Azure/AKSFlexNode/security/code-scanning/101
Resolves https://github.com/Azure/AKSFlexNode/security/code-scanning/4