The language Netherland/Dutch added#8669
Open
Eltrix-Dot wants to merge 4 commits intoAppFlowy-IO:mainfrom
Open
The language Netherland/Dutch added#8669Eltrix-Dot wants to merge 4 commits intoAppFlowy-IO:mainfrom
Eltrix-Dot wants to merge 4 commits intoAppFlowy-IO:mainfrom
Conversation
Add Dutch language support in language.dart
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds Dutch (Netherlands) as a supported UI language by wiring a new locale into the Flutter app and providing a full nl-NL translation file mirroring the existing en-US keys. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In
languageFromLocale, the new Dutch case is missing a terminating semicolon after"Nederlands", which will prevent the project from compiling. - Confirm that
nl-NL.jsonis placed in the correct directory used by the i18n loader (assets/translationsinInitAppWidgetTask), or update the path/config so the new locale file is actually loaded at runtime.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `languageFromLocale`, the new Dutch case is missing a terminating semicolon after `"Nederlands"`, which will prevent the project from compiling.
- Confirm that `nl-NL.json` is placed in the correct directory used by the i18n loader (`assets/translations` in `InitAppWidgetTask`), or update the path/config so the new locale file is actually loaded at runtime.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Eltrix-Dot
commented
Apr 16, 2026
Author
There was a problem hiding this comment.
I fixed my mistake
In languageFromLocale, the new Dutch case is missing a terminating semicolon after "Nederlands", which will prevent the project from compiling.
Confirm that nl-NL.json is placed in the correct directory used by the i18n loader (assets/translations in InitAppWidgetTask), or update the path/config so the new locale file is actually loaded at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
18n: Add Dutch (Netherlands) translation
So i added the Netherlands language.
PS i couldnt get it to Compile my terminal would constantly get a error midway trough.
Whats translated ->
I used the https://docs.appflowy.io/docs/documentation/appflowy/translation https://docs.appflowy.io/docs/documentation/appflowy/from-source/environment-setup/building-on-windows
But i could not get it to compile and test.
Sorry if i did anything wrong this is my first Pull Request on Github and i never worked with Flutter and Rust before i just wanted to add a language.
Summary by Sourcery
Add Dutch (Netherlands) as a supported application language and include its translations.
New Features: