adding documentation, fixing lint issues, defaulting to ensure=present, and fix onlyif script for removal so it only runs if the assembly to remove is currently installed into the GAC

Author: zappy-shu

manifests/gacassembly.pp

@@ -1,6 +1,22 @@
+# windowsgac::gacassembly - use to manage asseblies in the .NET Framework Global Assembly Cache
+#
+# @author Nick Adcock
+#
+# @param [present, absent] ensure
+#
+# @param [String] assemblypath
+#
+# @example Ensure $assembly installed into the GAC
+#   class { $assembly: }
+#
+# @example Ensure $assembly not in the GAC
+#   class { $assembly: 
+#       ensure => absent
+#   }
+
 define windowsgac::gacassembly (
     $assemblypath = $name,
-    $ensure,
+    $ensure = present,
 ) {
     $exists_script = sprintf('
         $full_name = [System.Reflection.AssemblyName]::GetAssemblyName("%s").FullName
@@ -10,27 +26,27 @@
     $get_enterprise_services_script = '
         [System.Reflection.Assembly]::Load("System.EnterpriseServices, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a")
         $publish = New-Object System.EnterpriseServices.Internal.Publish'
-    
+
     if $ensure == present {
         $command = sprintf('
             %s; $publish.GacInstall("%s")
             ', $get_enterprise_services_script, $assemblypath)
-        
-        exec { "GacInstall($assemblypath)": 
+
+        exec { "GacInstall(${assemblypath})":
             provider => powershell,
-            command => $command,
-            onlyif => "try { $exists_script; exit 1 } catch { exit 0 }"
-        }   
+            command  => $command,
+            onlyif   => "try { ${exists_script}; exit 1 } catch { exit 0 }",
+        }
     }
     else {
         $command = sprintf('
             %s; $publish.GacRemove("%s")
             ', $get_enterprise_services_script, $assemblypath)
-        
-        exec { "GacRemove($assemblypath)": 
+
+        exec { "GacRemove(${assemblypath})":
             provider => powershell,
-            command => $command,
-            onlyif => $exists_script
-        }   
+            command  => $command,
+            onlyif   => "try { ${exists_script}; exit 0 } catch { exit 1 }",
+        }
     }
 }

metadata.json

@@ -1,6 +1,6 @@
 {
     "name": "zappyshu-windowsgac",
-    "version": "1.0.0",
+    "version": "1.0.1",
     "author": "Zappy Shu",
     "summary": "Installs and removes .NET assemblies in the Global Assembly Cache",
     "license": "Apache-2.0",