unexpected output when using _embed with persons table

[timstallinger]

Version beta-3:

in db.json:

{
  "persons": [
    { "id": 0, "name": "Tim", "lastName": "S", "role": "developer" }
  ],
  "feedbacks": [
    { "id": 0, "personId": 0, "text": "Great dev"}
  ]
}

when requesting http://localhost:3000/feedbacks?_embed=person, I get

[
  {
    "id": 0,
    "personId": 0,
    "text": "Great dev"
  }
]

notice, how the person has not been embedded. However when I change the table name to something else like employees

{
  "employees": [
    { "id": 0, "name": "Tim", "lastName": "S", "role": "developer" }
  ],
  "feedbacks": [
    { "id": 0, "employeeId": 0, "text": "Great dev"}
  ]
}

I get the full expected result from http://localhost:3000/feedbacks?_embed=employee:

[
  {
    "id": 0,
    "employeeId": 0,
    "text": "Great dev",
    "employee": {
      "id": 0,
      "name": "Tim",
      "lastName": "S",
      "role": "developer"
    }
  }
]

Is persons a reserved table name or am I doing something wrong?

[drizzle042]

Based on the inflection API used by json-server, inflection.pluralize( 'person' ) === 'people' which is why persons does not work here as expected. See

const relatedData = db.data[inflection.pluralize(related)] as Item[] [in embed()]

[Omar-Tnt04]

I can reproduce this on v1.0.0-beta.6 (Windows 11, Node v24.12.0).

With persons resource

{
  "persons": [
    { "id": 0, "name": "Tim", "lastName": "S", "role": "developer" }
  ],
  "feedbacks": [
    { "id": 0, "personId": 0, "text": "Great dev" }
  ]
}

Request: GET /feedbacks?_embed=person

Result: The person object is not embedded.

[
  {
    "id": "0",
    "personId": 0,
    "text": "Great dev"
  }
]

With people resource

{
  "people": [
    { "id": "0", "name": "Tim", "lastName": "S", "role": "developer" }
  ],
  "feedbacks": [
    { "id": "0", "personId": "0", "text": "Great dev" }
  ]
}

Request: GET /feedbacks?_embed=person

Result: Works correctly.

[
  {
    "id": "0",
    "personId": "0",
    "text": "Great dev",
    "person": {
      "id": "0",
      "name": "Tim",
      "lastName": "S",
      "role": "developer"
    }
  }
]

Root cause

From reviewing src/service.ts (lines 35-58), when _embed gets a singular parameter like person, it calls inflection.pluralize() to find the resource. Since inflection.pluralize('person') returns 'people' (not 'persons'), the lookup for db.data['people'] fails when the resource is named persons.

This appears to be a mismatch between the resource name and what the inflection library expects for irregular plurals.

Workaround: Rename the resource to people instead of persons.

[Omar-Tnt04]

Opened a PR for this with a narrow fix and regression test.
It keeps the current inflection-based lookup and adds a minimal fallback for persons.