Fix linking issue - Squashed commit of adafruit#829

Author: tyeth

ci

@@ -0,0 +1 @@
+Subproject commit da37d5d2371435fa73fd5a1f4da7d92b7aafea26

src/Wippersnapper.cpp

@@ -32,8 +32,11 @@
  */
 
 #include "Wippersnapper.h"
+#include "Wippersnapper_Networking.h"
 
-Wippersnapper WS;
+// Define the global WS instance as the platform-specific derived class
+// This ensures virtual methods like _connect() route to the correct implementation
+Wippersnapper_WiFi WS;
 
 Wippersnapper::Wippersnapper() {
   _mqtt = 0; // MQTT Client object

src/Wippersnapper.h

@@ -501,6 +501,11 @@ class Wippersnapper {
   wippersnapper_signal_v1_CreateSignalRequest
       _outgoingSignalMsg; /*!< Outgoing signal message from device */
 };
-extern Wippersnapper WS; ///< Global member variable for callbacks
+
+// Include networking to get the platform-specific Wippersnapper_WiFi typedef
+#include "Wippersnapper_Networking.h"
+
+// // Global WS instance - defined as platform-specific type in Wippersnapper.cpp
+// extern Wippersnapper_WiFi WS; ///< Global member variable for callbacks
 
 #endif // ADAFRUIT_WIPPERSNAPPER_H

src/components/analogIO/Wippersnapper_AnalogIO.h

@@ -81,6 +81,5 @@ class Wippersnapper_AnalogIO {
   int32_t _totalAnalogInputPins;      /*!< Total number of analog input pins */
   analogInputPin *_analog_input_pins; /*!< Array of analog pin objects */
 };
-extern Wippersnapper WS; /*!< Wippersnapper variable. */
 
 #endif // WIPPERSNAPPER_DIGITALGPIO_H

src/components/digitalIO/Wippersnapper_DigitalGPIO.h

@@ -57,6 +57,5 @@ class Wippersnapper_DigitalGPIO {
   int32_t
       _totalDigitalInputPins; /*!< Total number of digital-input capable pins */
 };
-extern Wippersnapper WS;
 
 #endif // WIPPERSNAPPER_DIGITALGPIO_H

src/components/display/controller.h

@@ -43,5 +43,5 @@ class DisplayController {
       _hw_instances; ///< Holds pointers to DisplayHardware instances
   unsigned long _last_bar_update; ///< Timestamp of last status bar update
 };
-extern Wippersnapper WS; ///< Global WS instance
+
 #endif

src/components/ds18x20/ws_ds18x20.h

@@ -60,6 +60,5 @@ class ws_ds18x20 {
   std::vector<ds18x20Obj *>
       _ds18xDrivers; ///< Vec. of ptrs. to ds18x driver objects
 };
-extern Wippersnapper WS;
 
 #endif // WIPPERSNAPPER_DS18X20_H

src/components/i2c/WipperSnapper_I2C.h

@@ -232,6 +232,5 @@ class WipperSnapper_Component_I2C {
   WipperSnapper_I2C_Driver_Out_SH1107 *_sh1107 = nullptr;
   WipperSnapper_I2C_Driver_Out_Ssd1306 *_ssd1306 = nullptr;
 };
-extern Wippersnapper WS;
 
 #endif // WipperSnapper_Component_I2C_H

src/components/ledc/ws_ledc.h

@@ -55,6 +55,5 @@ class ws_ledc {
   bool analogWrite(uint8_t pin, int value);
   uint32_t tone(uint8_t pin, uint32_t freq);
 };
-extern Wippersnapper WS;
 
 #endif // ws_ledc_H

src/components/pixels/ws_pixels.h

@@ -68,5 +68,5 @@ class ws_pixels {
   void publishAddStrandResponse(bool is_success, char *pixels_pin_data);
   uint32_t getGammaCorrectedColor(uint32_t pixel_color, strand_s strand);
 };
-extern Wippersnapper WS;
+
 #endif // WS_PIXELS