Skip to content

Commit dd4da0e

Browse files
authored
Upgrade ci to test against all ruby versions (#76)
* Upgrade ci to test against all ruby versions * Update dummy app * Fix rake file and remove unused railtie file * Remove files * fix 3.1 support
1 parent c6c10aa commit dd4da0e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+930
-391
lines changed

.github/workflows/lint.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@ jobs:
1111
runs-on: ubuntu-latest
1212
name: Linting
1313
steps:
14-
- uses: actions/checkout@v4
14+
- uses: actions/checkout@v6
1515
- name: Set up Ruby
1616
uses: ruby/setup-ruby@v1
17+
with:
18+
ruby-version: '4.0'
1719
- name: Install dependencies
1820
run: bundle install
1921
- name: Run tests

.github/workflows/test.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,12 @@ jobs:
1515
fail-fast: false
1616
matrix:
1717
database: [mysql, postgres, sqlite]
18+
ruby-version:
19+
- 3.1
20+
- 3.2
21+
- 3.3
22+
- 3.4
23+
- 4.0
1824
services:
1925
mysql:
2026
image: mysql:8.0.31
@@ -32,15 +38,15 @@ jobs:
3238
env:
3339
TARGET_DB: ${{ matrix.database }}
3440
steps:
35-
- uses: actions/checkout@v4
41+
- uses: actions/checkout@v6
3642
- name: Set up Ruby
3743
uses: ruby/setup-ruby@v1
44+
with:
45+
ruby-version: ${{ matrix.ruby-version }}
3846
- name: Install dependencies
3947
run: bundle install
4048
- name: Setup db
4149
run: |
42-
cd test/dummy
4350
bin/rails db:setup
44-
cd ../../
4551
- name: Run tests
4652
run: bin/test

.ruby-version

Lines changed: 0 additions & 1 deletion
This file was deleted.

Rakefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
# frozen_string_literal: true
2-
31
require "bundler/setup"
42

3+
APP_RAKEFILE = File.expand_path("test/dummy/Rakefile", __dir__)
4+
load "rails/tasks/engine.rake"
5+
56
require "bundler/gem_tasks"

bin/rails

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
#!/usr/bin/env ruby
2+
# This command will automatically be run when you run "rails" with Rails gems
3+
# installed from the root of your application.
4+
5+
ENGINE_ROOT = File.expand_path("..", __dir__)
6+
ENGINE_PATH = File.expand_path("../lib/solid_cable/engine", __dir__)
7+
APP_PATH = File.expand_path("../test/dummy/config/application", __dir__)
8+
9+
# Set up gems listed in the Gemfile.
10+
ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
11+
require "bundler/setup" if File.exist?(ENV["BUNDLE_GEMFILE"])
12+
13+
require "rails/all"
14+
require "rails/engine/commands"

lib/solid_cable/railtie.rb

Lines changed: 0 additions & 6 deletions
This file was deleted.

solid_cable.gemspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,6 @@ Gem::Specification.new do |spec|
2626
spec.add_dependency "activejob", rails_version
2727
spec.add_dependency "actioncable", rails_version
2828
spec.add_dependency "railties", rails_version
29+
30+
spec.add_development_dependency "minitest", "~> 5.0"
2931
end

test/config_stubs.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ module ConfigStubs
44
extend ActiveSupport::Concern
55

66
class ConfigStub
7-
def initialize(**)
7+
def initialize(**opts)
88
@config = ActiveSupport::OrderedOptions.new.
9-
update({ adapter: :test }.merge(**))
9+
update({ adapter: :test }.merge(**opts))
1010
end
1111

1212
def config_for(_file)
@@ -23,7 +23,7 @@ def run!
2323
end
2424
end
2525

26-
def with_cable_config(**)
27-
Rails.stub(:application, ConfigStub.new(**)) { yield }
26+
def with_cable_config(**opts)
27+
Rails.stub(:application, ConfigStub.new(**opts)) { yield }
2828
end
2929
end

test/dummy/Rakefile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# frozen_string_literal: true
2-
31
# Add your own tasks in files placed in lib/tasks ending in .rake,
42
# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
53

test/dummy/app/assets/images/.keep

Whitespace-only changes.

0 commit comments

Comments
 (0)