Skip to content

[Merged by Bors] - chore(LinearAlgebra/Dimension): move proof of finrank_le_finrank_of_surjective earlier#38129

Closed
artie2000 wants to merge 1 commit intoleanprover-community:masterfrom
artie2000:move-lemma
Closed

[Merged by Bors] - chore(LinearAlgebra/Dimension): move proof of finrank_le_finrank_of_surjective earlier#38129
artie2000 wants to merge 1 commit intoleanprover-community:masterfrom
artie2000:move-lemma

Conversation

@artie2000
Copy link
Copy Markdown
Collaborator

  • Move LinearMap.finrank_le_finrank_of_surjective one file earlier by simplifying the proof to match LinearMap.finrank_le_finrank_of_injective

Open in Gitpod

@github-actions
Copy link
Copy Markdown

PR summary 105b370555

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Apr 16, 2026
@artie2000 artie2000 added the easy < 20s of review time. See the lifecycle page for guidelines. label Apr 17, 2026
@themathqueen
Copy link
Copy Markdown
Collaborator

The title confused me. Can you change it to "move earlier" or something?

Thanks!

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by themathqueen.

@mathlib-triage mathlib-triage bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Apr 17, 2026
@riccardobrasca
Copy link
Copy Markdown
Member

I agree the title should be fixed, otherwise LGTM, thanks!

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 17, 2026

✌️ artie2000 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-triage mathlib-triage bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Apr 17, 2026
@artie2000 artie2000 changed the title chore(LinearAlgebra/Dimension): generalise proof of finrank_le_finrank_of_surjective chore(LinearAlgebra/Dimension): move proof of finrank_le_finrank_of_surjective earlier Apr 17, 2026
@artie2000
Copy link
Copy Markdown
Collaborator Author

thanks both
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Apr 17, 2026
…surjective` earlier (#38129)

* Move `LinearMap.finrank_le_finrank_of_surjective` one file earlier by simplifying the proof to match `LinearMap.finrank_le_finrank_of_injective`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Apr 17, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(LinearAlgebra/Dimension): move proof of finrank_le_finrank_of_surjective earlier [Merged by Bors] - chore(LinearAlgebra/Dimension): move proof of finrank_le_finrank_of_surjective earlier Apr 17, 2026
@mathlib-bors mathlib-bors bot closed this Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants