Skip to content

The approved sites endpoint does not return the client name #1186

@jacogasp

Description

@jacogasp

The /api/approved endpoint does not return the client name, nor the client description.

The current dashboard displays the client name and description by fetching the both the approved sites and the client list, joining them on the frontend. The /api/approved endpoint also returns a userId entry that is not clear what represents. Since the endpoint must return only the sites approved by the user itself, most probably it is a redundant information.

The expected behavior is that the /api/approved endpoint returns the client name and the client description, without the user id. Perhaps the timeoutDate is also not necessary.
Lastly, I suppose that the creationDate represents the date on which the user authorized the client for the first time. Maybe it could be rename as authorizationDate.

Current behavior:

[{
    "id": 255,
    "userId": "jacopo",
    "clientId": "ffc58058-25a7-4a91-a74a-21b4c6fd82e7",
    "creationDate": "2024-11-07T15:45:51+0100",
    "accessDate": "2026-01-22T16:19:05+0100",
    "timeoutDate": null,
    "allowedScopes": ["scim:read", "scim:write", "iam:admin.read", "openid", "email", "profile"]
}]

Expected behavior:

[{
    "id": 255,
    "clientId": "ffc58058-25a7-4a91-a74a-21b4c6fd82e7",
    "clientName": "dashboard-nextjs",
    "clientDescription": "Client for iam-dashboard.cloud.cnaf.infn.it"
    "authorizationDate": "2024-11-07T15:45:51+0100",
    "accessDate": "2026-01-22T16:19:05+0100",
    "timeoutDate": null,
    "allowedScopes": ["scim:read", "scim:write", "iam:admin.read", "openid", "email", "profile"]
}]

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions