Skip to content

Handle special fields like localized names in tag removal logic #12075

@tyrasd

Description

@tyrasd

More follow-ups for #11696:

  • for fields of type localized: When changing a feature from a preset that had a name field (of type localized) and one changes it to a preset without a corresponding name field, only the base name tag is removed during the tag upgrade, but any localized names are preserved. Example: craft=key_cutter name=foo name:en=bar when changed to a recycling bin will end up as amenity=recycling recycling_type=container name:en=bar). This should consistently remove either all names or none.
  • for fields of type multiCombo it does not remove the old tags when the new preset does not have a field for the corresponding tag(s). Example: amenity=recycling recycling_type=container recycling:plastic=yes recycling:=invalid ends up as craft=key_cutter recycling:plastic=yes (note that only the recycling:=invalid was removed because that's how the tag key prefix is defined in the field's key property). This should remove all corresponding tags with a key that matches the field's prefix.
  • more?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugA bug - let's fix this!presetAn issue with an OpenStreetMap preset or tag

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions