refactor(Algebra/Order): unbundle group and ring cone#37298
refactor(Algebra/Order): unbundle group and ring cone#37298artie2000 wants to merge 7 commits intoleanprover-community:masterfrom
Conversation
PR summary 35471d41e9Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Algebra.Order.Group.Cone | 348 | 659 | +311 (+89.37%) |
| Mathlib.Algebra.Order.Ring.Cone | 414 | 692 | +278 (+67.15%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Algebra.Order.Ring.Cone |
278 |
Mathlib.Algebra.Order.Group.Cone |
311 |
Declarations diff
+ IsOrderedMonoid.mkOfSubmonoid
+ IsOrderedRing.mkOfSubsemiring
+ LinearOrder.mkOfSubmonoid
+ PartialOrder.mkOfSubmonoid
+ PartialOrder.mkOfSubmonoid_le_iff
+ Submonoid.oneLE.isMulPointed
+ Submonoid.oneLE.isMulSpanning
+ Subsemiring.nonneg.isPointed
+ Subsemiring.nonneg.isSpanning
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
Increase in tech debt: (relative, absolute) = (3.00, 0.12)
| Current number | Change | Type |
|---|---|---|
| 25 | 3 | disabled deprecation lints |
Current commit 85c2dc228d
Reference commit 35471d41e9
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
|
Could you please extend the PR description explaining why this is desired or what thee benefits are? And if there is a relevant Zulip discussion, could you please link that, too? Not sure I'm the right person to review. I'll unassign myself for now but keep this on my list to revisit again |
GroupConeandRingConeusingSubmonoid.IsMulPointedThe material in
Mathlib.Algebra.Group.Submonoid.Supportwas created to treat uniformlyThis PR deprecates the GroupCone and RingCone structures, making use of the predicates
Submonoid.IsMulPointedandAddSubmonoid.IsPointeddefined in that file instead.See also #36863 for the analogous change to ring orderings.