refactor: replace tsconfk

Author: segunadebayo

.changeset/replace-tsconfck-get-tsconfig.md

@@ -0,0 +1,6 @@
+---
+'@pandacss/node': patch
+---
+
+Replace discontinued `tsconfck` with [`get-tsconfig`](https://github.com/privatenumber/get-tsconfig) for resolving and
+parsing `tsconfig.json` (including `extends`).

packages/node/__tests__/find-tsconfig-path.test.ts

@@ -0,0 +1,80 @@
+import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs'
+import path from 'node:path'
+import { tmpdir } from 'node:os'
+import { describe, expect, test } from 'vitest'
+import { findClosestTsconfig, resolveDirectTsconfigJson } from '../src/tsconfig-utils'
+
+describe('findClosestTsconfig', () => {
+  test('finds tsconfig in the same directory as the config file', async () => {
+    const dir = mkdtempSync(path.join(tmpdir(), 'panda-tsconfig-'))
+    try {
+      const tsconfigPath = path.join(dir, 'tsconfig.json')
+      writeFileSync(tsconfigPath, JSON.stringify({ compilerOptions: { paths: { '@/*': ['./src/*'] } } }))
+      const pandaConfig = path.join(dir, 'panda.config.ts')
+      writeFileSync(pandaConfig, 'export default {}')
+
+      await expect(findClosestTsconfig(pandaConfig, dir)).resolves.toBe(tsconfigPath)
+    } finally {
+      rmSync(dir, { recursive: true, force: true })
+    }
+  })
+
+  test('walks up to a parent directory', async () => {
+    const root = mkdtempSync(path.join(tmpdir(), 'panda-tsconfig-'))
+    try {
+      const tsconfigPath = path.join(root, 'tsconfig.json')
+      writeFileSync(tsconfigPath, '{}')
+      const sub = path.join(root, 'packages', 'app')
+      mkdirSync(sub, { recursive: true })
+      const pandaConfig = path.join(sub, 'panda.config.ts')
+      writeFileSync(pandaConfig, 'export default {}')
+
+      await expect(findClosestTsconfig(pandaConfig, root)).resolves.toBe(tsconfigPath)
+    } finally {
+      rmSync(root, { recursive: true, force: true })
+    }
+  })
+
+  test('does not search above root (matches tsconfck root option)', async () => {
+    const outer = mkdtempSync(path.join(tmpdir(), 'panda-tsconfig-'))
+    try {
+      writeFileSync(path.join(outer, 'tsconfig.json'), '{}')
+      const inner = path.join(outer, 'nested', 'pkg')
+      mkdirSync(inner, { recursive: true })
+      const pandaConfig = path.join(inner, 'panda.config.ts')
+      writeFileSync(pandaConfig, 'export default {}')
+
+      await expect(findClosestTsconfig(pandaConfig, inner)).resolves.toBeNull()
+    } finally {
+      rmSync(outer, { recursive: true, force: true })
+    }
+  })
+})
+
+describe('resolveDirectTsconfigJson', () => {
+  test('resolves when conf.path is a tsconfig.json file', async () => {
+    const dir = mkdtempSync(path.join(tmpdir(), 'panda-tsconfig-'))
+    try {
+      const tsconfigPath = path.join(dir, 'tsconfig.json')
+      writeFileSync(tsconfigPath, '{}')
+      await expect(resolveDirectTsconfigJson(tsconfigPath)).resolves.toBe(path.resolve(tsconfigPath))
+    } finally {
+      rmSync(dir, { recursive: true, force: true })
+    }
+  })
+
+  test('returns null for non-json paths', async () => {
+    await expect(resolveDirectTsconfigJson('/tmp/foo.ts')).resolves.toBeNull()
+  })
+
+  test('throws when path exists but is not a file (tsconfck resolveTSConfigJson parity)', async () => {
+    const dir = mkdtempSync(path.join(tmpdir(), 'panda-tsconfig-'))
+    try {
+      const tsconfigDir = path.join(dir, 'tsconfig.json')
+      mkdirSync(tsconfigDir)
+      await expect(resolveDirectTsconfigJson(tsconfigDir)).rejects.toThrow(/exists but is not a regular file/)
+    } finally {
+      rmSync(dir, { recursive: true, force: true })
+    }
+  })
+})

packages/node/__tests__/fixtures/solution-mixed/src/foo.ts

@@ -0,0 +1 @@
+export const foo = 1

packages/node/__tests__/fixtures/solution-mixed/src/panda.config.ts

@@ -0,0 +1 @@
+export default {}

packages/node/__tests__/fixtures/solution-mixed/tsconfig.base.json

@@ -0,0 +1,6 @@
+{
+  "compilerOptions": {
+    "composite": true,
+    "strictNullChecks": true
+  }
+}

packages/node/__tests__/fixtures/solution-mixed/tsconfig.json

@@ -0,0 +1,5 @@
+{
+  "files": [],
+  "include": [],
+  "references": [{ "path": "./tsconfig.src.json" }, { "path": "./tsconfig.test.json" }]
+}

packages/node/__tests__/fixtures/solution-mixed/tsconfig.src.json

@@ -0,0 +1,12 @@
+{
+  "extends": "./tsconfig.base",
+  "include": ["src/**/*"],
+  "exclude": ["src/**/*.spec.ts"],
+  "compilerOptions": {
+    "strict": true,
+    "baseUrl": ".",
+    "paths": {
+      "@pkg/*": ["./src/*"]
+    }
+  }
+}

packages/node/__tests__/fixtures/solution-mixed/tsconfig.test.json

@@ -0,0 +1,7 @@
+{
+  "extends": "./tsconfig.base",
+  "include": ["src/**/*.spec.ts"],
+  "compilerOptions": {
+    "strict": false
+  }
+}

packages/node/__tests__/load-tsconfig.solution.test.ts

@@ -0,0 +1,37 @@
+import path from 'node:path'
+import { fileURLToPath } from 'node:url'
+import { describe, expect, test } from 'vitest'
+import type { LoadConfigResult } from '@pandacss/types'
+import { loadTsConfig } from '../src/load-tsconfig'
+
+const fixtureDir = path.join(path.dirname(fileURLToPath(import.meta.url)), 'fixtures', 'solution-mixed')
+
+function mockConf(configPath: string): LoadConfigResult {
+  return {
+    path: configPath,
+    config: {} as LoadConfigResult['config'],
+    serialized: '',
+    deserialize: () => ({}) as LoadConfigResult['config'],
+    dependencies: [],
+    hooks: {},
+  }
+}
+
+describe('loadTsConfig + TypeScript project references', () => {
+  test('resolves to referenced tsconfig.src.json for sources under src/', async () => {
+    const pandaPath = path.join(fixtureDir, 'src', 'panda.config.ts')
+    const cwd = fixtureDir
+    const result = await loadTsConfig(mockConf(pandaPath), cwd)
+
+    expect(result?.tsconfigFile).toBe(path.join(fixtureDir, 'tsconfig.src.json'))
+    expect(result?.tsconfig?.compilerOptions).toBeDefined()
+  })
+
+  test('falls back to root tsconfig when file is not in any referenced project', async () => {
+    const pandaPath = path.join(fixtureDir, 'panda.config.ts')
+    const cwd = fixtureDir
+    const result = await loadTsConfig(mockConf(pandaPath), cwd)
+
+    expect(result?.tsconfigFile).toBe(path.join(fixtureDir, 'tsconfig.json'))
+  })
+})

packages/node/__tests__/resolve-ts-base-url.test.ts

@@ -0,0 +1,21 @@
+import path from 'node:path'
+import { describe, expect, test } from 'vitest'
+import { resolveBaseUrlForCompilerOptions } from '../src/tsconfig-utils'
+
+describe('resolveBaseUrlForCompilerOptions', () => {
+  const cwd = '/project'
+  const tsconfig = '/project/packages/app/tsconfig.json'
+
+  test('uses cwd when baseUrl is omitted', () => {
+    expect(resolveBaseUrlForCompilerOptions(undefined, tsconfig, cwd)).toBe(cwd)
+  })
+
+  test('resolves relative baseUrl against the tsconfig directory', () => {
+    expect(resolveBaseUrlForCompilerOptions('.', tsconfig, cwd)).toBe(path.resolve('/project/packages/app'))
+    expect(resolveBaseUrlForCompilerOptions('./src', tsconfig, cwd)).toBe(path.resolve('/project/packages/app/src'))
+  })
+
+  test('leaves absolute baseUrl unchanged', () => {
+    expect(resolveBaseUrlForCompilerOptions('/abs/base', tsconfig, cwd)).toBe('/abs/base')
+  })
+})